Simplify code to use null

* which-key.el (which-key--create-buffer-and-show):
Use null.

; Change defcustom types to natnum

* which-key.el
(which-key-frame-max-width, which-key-frame-max-height):
Change defcustom type integer to natnum.

Fix labeling of functions in which-key popup

Add a few minor changes.

Merge remote-tracking branch 'origin/master'

* which-key.el (which-key--create-pages): Untabify.

* which-key.el (which-key--pad-column): Untabify.

; * which-key.el (which-key--get-keymap-bindings-1): Use eql.

; * which-key.el (which-key--truncate-description): Untabify.

Use string-empty-p for readability.

* which-key.el (which-key--maybe-get-prefix-title):
Use string-empty-p for readability.

Don't quote t

* which-key.el (which-key--replace-in-repl-list-many):
Don't quote t.

Use declare form instead of put for clarity

* which-key.el (which-key-add-keymap-based-replacements):
Use declare form instead of put property.

Merge pull request #367 from tarsiiformes/long-gone

Remove reference to long gone which-key-manual-update

* which-key.el (which-key--paging-functions): Remove reference to
which-key-manual-update.

This commands was remove in 42a25055163141165aa0269dbca69735e704825c.

Remove unnecessary eval-when-compile

* which-key.el (which-key--ignore-non-evil-keys-regexp):
Remove unnecessary eval-when-compile in regexp-opt.

Replace internet link by Info node

* which-key.el (which-key-hide-alt-key-translations):
Replace internet link by Info node.

; Replace tabs by spaces

* which-key.el (which-key--paging-functions):  Replace tabs by spaces.

Sharp quote which-key-sort-order default.

Remove unnecessary :group attributes

* which-key.el:  Remove :group 'which-key in defcustoms.
(which-key-idle-delay):
(which-key-idle-secondary-delay):
(which-key-echo-keystrokes):
(which-key-max-description-length):
(which-key-min-column-description-width):
(which-key-add-column-padding):
(which-key-unicode-correction):
(which-key-dont-use-unicode):
(which-key-separator):
(which-key-ellipsis):
(which-key-prefix-prefix):
(which-key-compute-remaps):
(which-key-replacement-alist):
(which-key-allow-multiple-replacements):
(which-key-show-docstrings):
(which-key-highlighted-command-list):
(which-key-special-keys):
(which-key-buffer-name):
(which-key-show-prefix):
(which-key-popup-type):
(which-key-min-display-lines):
(which-key-max-display-columns):
(which-key-side-window-location):
(which-key-side-window-slot):
(which-key-side-window-max-width):
(which-key-side-window-max-height):
(which-key-frame-max-width):
(which-key-frame-max-height):
(which-key-allow-imprecise-window-fit):
(which-key-show-remaining-keys):
(which-key-sort-order):
(which-key-sort-uppercase-first):
(which-key-paging-prefixes):
(which-key-paging-key):
(which-key-use-C-h-commands):
(which-key-show-early-on-C-h):
(which-key-is-verbose):
(which-key-preserve-window-configuration):
(which-key-hide-alt-key-translations):
(which-key-delay-functions):
(which-key-allow-regexps):
(which-key-inhibit-regexps):
(which-key-show-transient-maps):
(which-key-init-buffer-hook):

Replace member by memq for clarity

* which-key.el (which-key--side-window-max-dimensions):
Replace member by memq.

Use declare form instead of put, for clarity

* which-key.el (which-key-add-major-mode-key-based-replacements):
Use declare form instead of put.

; Use string-join to simplify and make meaning explicit

* which-key.el (which-key--butlast-string):  Replace mapconcat by string-join.

Remove github reference in preparation for integration to Emacs core

* which-key.el:  Remove github reference.

Specify more precise customization type, natnum instead of integer

* which-key.el (which-key-add-column-padding):  Use natnum

; Add sharp-quotes to function names

Replace quoted list by (list ...) where each
element is sharp-quoted so that the byte-compiler can check if the
functions exist.

* which-key.el (which-key--paging-functions):  Add sharp-quotes to
function names.

Remove unnecessary eval-when-compile from definition

* which-key.el (which-key--ignore-keys-regexp):  Remove eval-when-compile.

Disentangle third party libraries (but keep support for now)

Add `which-key-inhibit-display-hook' to allow third-party libraries to prevent
which-key from displaying in certain circumstances. Add
`which-key-this-command-keys-function' as a customizable variable to allow
third-party libraries to teach which-key about custom symbols they insert into
the key sequence.

Add `which-key-evil-this-operator-p', `which-key-god-mode-self-insert-p' and
`which-key--god-mode-this-command-keys' to provide support for god-mode and evil
using the new mechanisms.

Remove "Internal" from docstrings of defvars

The internal status is implied by the double hyphen in the name.

Bump year to 2024

* which-key.el:  Bump year

Simplify test for empty list

* which-key.el (which-key--show-keymap):  Use (null)

Mention affected settings of which-key-dont-use-unicode

* which-key.el (which-key-separator):  Improve docstring

Add a :version tag to all defcustom's and defface's

* which-key.el: add :version tag to all following
(which-key-idle-delay):
(which-key-idle-secondary-delay):
(which-key-echo-keystrokes):
(which-key-max-description-length):
(which-key-min-column-description-width):
(which-key-add-column-padding):
(which-key-unicode-correction):
(which-key-dont-use-unicode):
(which-key-separator):
(which-key-ellipsis):
(which-key-prefix-prefix):
(which-key-compute-remaps):
(which-key-replacement-alist):
(which-key-allow-multiple-replacements):
(which-key-show-docstrings):
(which-key-highlighted-command-list):
(which-key-special-keys):
(which-key-buffer-name):
(which-key-show-prefix):
(which-key-popup-type):
(which-key-min-display-lines):
(which-key-max-display-columns):
(which-key-side-window-location):
(which-key-side-window-slot):
(which-key-side-window-max-width):
(which-key-side-window-max-height):
(which-key-frame-max-width):
(which-key-frame-max-height):
(which-key-allow-imprecise-window-fit):
(which-key-show-remaining-keys):
(which-key-sort-order):
(which-key-sort-uppercase-first):
(which-key-paging-prefixes):
(which-key-paging-key):
(which-key-use-C-h-commands):
(which-key-show-early-on-C-h):
(which-key-is-verbose):
(which-key-preserve-window-configuration):
(which-key-hide-alt-key-translations):
(which-key-delay-functions):
(which-key-allow-regexps):
(which-key-inhibit-regexps):
(which-key-show-transient-maps):
(which-key-init-buffer-hook):
(which-key-key-face):
(which-key-separator-face):
(which-key-note-face):
(which-key-command-description-face):
(which-key-local-map-description-face):
(which-key-highlighted-command-face):
(which-key-group-description-face):
(which-key-special-key-face):
(which-key-docstring-face):
(which-key-custom-popup-max-dimensions-function):
(which-key-custom-hide-popup-function):
(which-key-custom-show-popup-function):
(which-key-lighter):
(which-key-allow-evil-operators):
(which-key-show-operator-state-maps):

Format first sentences of docstrings.

Ensure a complete sentence (at least a phrase with a period at the end) that
fits on one line.

* which-key.el: Add two spaces in docstrings and punctation

(which-key-echo-keystrokes):
(which-key-popup-type):
(which-key-min-display-lines):
(which-key-side-window-location):
(which-key-show-early-on-C-h):
(which-key-allow-regexps):
(which-key-group-description-face):
(which-key-docstring-face):
(which-key-enable-god-mode-support):
(which-key-setup-minibuffer):
(which-key-add-keymap-based-replacements):
(which-key--maybe-replace):
(which-key--maybe-add-docstring):
(which-key--get-keymap-bindings):
(which-key-reload-key-sequence):

Fix popup with no space

Fixes #317

Add which-key-C-h-map-prompt to make it customizable

Fixes #350

Remove old "recent changes" from README

Catch errors in kbd

Fixes #346

Merge commit 'pullreqs/343'

Ignore .DS_Store

Merge pull request #342 from tarsiiformes/quote-quote

Replace or quote certain single quotes in docstrings

Allow truncating without using any ellipsis

Depending on how bindings are displayed showing docstrings can result
in most lines being too long and adding ellipses to most lines can be
quite ugly and distracting.

Don't make description longer than allowed when truncating

Truncating the description to the allowed maximal length and then
appending an ellipsis, makes the final text longer than allowed.
The length of the ellipsis has to be taken into account.

Support different types for which-key-max-description-length

Using a function is useful, e.g., to use a different maximal
width, depending on the value of `which-key-show-docstrings'.

Avoid unnecessary work

Fix vertical off-by-one error

When the usage information is displayed at the top or bottom (as
controlled by `which-key-show-prefix'), then we already accounted
for that by putting (- max-height 1) bindings in each row.  But
we did not ensure that the max-height is used when displaying the
result.  Instead we used (- max-height 1) here too.

When trying to display usage information at the bottom, the result is
that it is not displayed because it is off-window.  When displaying at
the top, then it is displayed, but the last binding is off-window and
never displayed.

This bug did not matter (much) when using the default settings because
then the code used for displaying the window actually ignores the
max-height and just uses the height appropriate to display all lines
in the buffer (i.e., (+ max-height 1)).  However, other display
methods, including but not necessarily limited to third-party methods
(such as `which-key-posframe') may choose to, or absolutely have to,
respect max-height.  In particular, anything that tries to use the
full height of a frame or window, will be affected by this.

Fix horizontal off-by-one error

Delay increasing width used by columns until we know that we have to
do so because we have determined that there is enough room to add an
additional column and a space between the last two columns.

If we don't do that, then we can easily get an off-by-one error.  If
docstrings are shown and the window is narrow, then it is likely that
we end up using the maximal width.  If we then add one to the actual
width and later compare that again with the maximal width, then that
is too width.

Don't pad beyond maximal width

The old implementation behaved as if the "description" is the only
information that is being displayed, however in actuality the
available width has to be shared with the key (and the separator
between the two).

Failing to take that into account meant that every binding whose
description isn't *by itself* wider than the width available to
display all the information got excessive padding, which later has to
be removed during truncation again (resulting in misleading ellipses).

Displaying just one column means pages are arranged vertically

Third-party display methods may do that without using a side-window,
and therefore they don't set `which-key-popup-type' to `side-window'.
Likewise they might not set `which-key-side-window-location', e.g.,
because their display method only supports one location.

`which-key-max-display-columns' being 1 is by itself already enough
of an indicator to know that there won't be multiple columns.

Calculate format string only once

Replace or quote certain single quotes in docstrings

The byte-compiler recently got more fussy about quotes.

Add group to minor-mode definition

Fixes #339

Merge remote-tracking branch 'origin/master'

Add an example to README for keymap binding

See #338

Bump version

Don't allow transient maps when prefix length is zero.

Fixes #335

Fix typo in ellipsis

Merge pull request #329 from hans-d/feat-elipsis

add which-key-elipsis

Merge branch 'feat-columnsize'

Fix code column width

Merge pull request #331 from skangas/gnu-elpa-badge

Add GNU ELPA badge

Add GNU ELPA badge to README.org

add which-key-elipsis

add which-key-min-column-description-width

Update to the newer advice API

Patch submitted by Stefan Monnier

Fix key-chord handling

It turns out we don't need to do anything too tricky for key-chords, because
this-single-command-raw-keys returns the correct key-sequence

Fixes #254

Respect which-key-min-display-lines setting

Fixes #325

Allow binding to symbols in which-key-C-h-dispatch

Fixes #326

Merge pull request #327 from anis-semmar/patch-1

README.org: fix page flipping command names

Merge pull request #321 from fredericgiquel/preserve-window-configuration

Preserve window configuration

README.org: fix page flipping command names

`which-key-show-next-page` / `which-key-show-previous-page` do not exist, state the correct command name.

Merge pull request #323 from Zetagon/master

Add missing argument to function call

Add missing argument to function call

Add option (default off) to restore window configuration

Merge pull request #313 from duncanburke/master

Add support for help-char being a generalized input event

Preserve window configuration

Merge pull request #315 from peniblec/keymap-names

Fix some keymap names not showing up

Fix some keymap names not showing up

Closes #314.

Add support for help-char being a generalized input event

Not all keyboard events can be represented as a character. For example,
while ?\C-h is a character, represented as 8 in decimal, C-M-h is
represented by 134217736 in decimal, as can be obtained from:

(elt (kbd "C-M-h") 0)

It is useful to allow help-char to be set to something other than a
character, as characters cover only a very small region of possible
input events. This is especially important because help-char is used to
bring up the pagination menu (when which-key-use-C-h-commands is t), and
this won't work if it conflicts with any keybinding within the prefix
command that led to the activation of which-key.

If help-char is left set to ?\C-h things work fine because as a
convention keymaps avoid binding that due to it being the default
binding for help. That is just a convention, however, and things become
more difficult with a heavily user-customized set of keybindings that
preclude the use of ?\C-h for that purpose.

In that case, if ?\C-h cannot be used, it is much easier to find a
binding for help-char that is unlikely to conflict with any bindings if
it is permitted to use the full range of modifier keys.

This patch modifies which-key--next-page-hint, which is the only place
that broke when I set help-char to a keyboard event that wasn't a
character. Rather than doing a string comparison, help-char and prefix
keys are put in vectors and equality is checked that way.

Remove more instances of obsolete variables.

Merge remote-tracking branch 'origin/master'

Remove some obsolete variables/functions

Don't require evil in which-key-tests.el

Patch from Stefan Monnier

Fix compiler warnings

Fixes #312

Handle closure definition type

Fixes #311

Improve which-key-add-keymap-based-replacements.

Also, teach which-key--safe-lookup-key to handle numeric results.

Clarify usage of keymap replacements in docstrings and README

Clean up some docstrings

Clean up which-key--maybe-replace

Improve which-key-add-keymap-based-bindings

Add a test

Fix key sort order functions

We now always get the full key description (prefix + binding)

Try again to fix tests

Turn off fail-fast in github action

Try without cask

Add install python step to github action

Fix which-key--group-p

length> is a new function maybe

Try with cask again

Fix github action

Fix test

Update README

Make enable-extended-define-key obsolete